search

markfairbanks / tidytable

Tidy interface to 'data.table'
https://markfairbanks.github.io/tidytable/
Other
449 stars 33 forks source link

In operator fallback to base #634

Closed krterberg closed 1 year ago

krterberg commented 1 year ago

Have %in% fall back to standard library behaviour when vec_in can't be used. Add note about possibility of performance regression when incompatible types are supplied. Closes #632

krterberg commented 1 year ago

Updated!

krterberg commented 1 year ago

Haha I was terribly confused why devtools::check() was suddenly failing badly, I'll try again.

markfairbanks commented 1 year ago

Thanks again for the help 😄

markfairbanks commented 1 year ago

Would you like to be added to the contributor list? Basically your name would show up here and here under the authors as a contributor (once the new version of tidytable is on CRAN)

markfairbanks commented 1 year ago

@krterberg - just checking on this one more time since I'm about to release v0.9.1 - would you like to be added to the contributor list? Basically your name would show up here and here under the authors as a contributor (once the new version of tidytable is on CRAN)

krterberg commented 1 year ago

Oh that's very kind of you to offer. Sure, you can credit me as Koen ter Berg, and if there's any other issues I could contribute to I'd be happy to.

markfairbanks commented 1 year ago

Thanks again for contributing 😄

Feel free to contribute wherever - whether it's an existing issue or one you find later on.