markfasheh / duperemove

Tools for deduping file systems
GNU General Public License v2.0
816 stars 81 forks source link

Print more info for users #131

Closed nefelim4ag closed 8 years ago

markfasheh commented 8 years ago

Awesome thanks for these patches. Checking the hash vs db in particular has been on my todo list.

I've got them in a branch, I'll cherry pick most of them into master myself. One thing - I'm not sure we need strcimp(). The hash id for each hash will not change unless there's an incompatible change required (in which case we'd treat it as a different hash).

nefelim4ag commented 8 years ago

P.S. @markfasheh, i've add strcicmp() because db store hash name (in config) with capital letter, but in code lowercase letter used.

markfasheh commented 8 years ago

Ahh indeed you are correct, we have:

define HASH_TYPE_MURMUR3 "Murmur3 "

and then this:

define DEFAULT_HASH_STR "murmur3"

and finally we do this when picking a module:

            if (strcasecmp(type, m->name) == 0)
                    break;

Oh bother...

That said, we can still use strcasemp in the dbfile code so I'll just change it to that.

nefelim4ag commented 8 years ago

Thanks