search

markfasheh / duperemove

Tools for deduping file systems
GNU General Public License v2.0
816 stars 81 forks source link

hang at end of dedupe #154

Closed matthiaskrgr closed 8 years ago

matthiaskrgr commented 8 years ago

this was with https://github.com/markfasheh/duperemove/commit/7bb50b3a8ffd23c1e74a43c611286f9c6ce0d9cc

Have sufficiently large file of a normal user Make non-cow copy as root (different permissions) ( cat file > file2 ) dedupe the files as root At the end of dedupe, duperemove will appear to hang.

backtrace (if I did this right) was hash-tree.c:407

echo t > /proc/sysrq-trigger only got me [201324.588838] sysrq: SysRq : This sysrq operation is disabled. in dmesg

markfasheh commented 8 years ago

Ahh ok that reproduces immediately for me, I probably messed up that patch. disregard this branch then until i get a chance to fix this up the right way.

markfasheh commented 8 years ago

So the hang from https://github.com/markfasheh/duperemove/commit/7bb50b3a8ffd23c1e74a43c611286f9c6ce0d9cc shouldn't happen, you did mention that you got the hang at least once testing master branch? Do you still see that at all?

markfasheh commented 8 years ago

Oh btw I say 'shouldn't happen' because we replaced that patch with something that works :)

ivanbaldo commented 8 years ago

@matthiaskrgr ping

matthiaskrgr commented 8 years ago

Looks fixed here, thanks.