search

markfasheh / duperemove

Tools for deduping file systems
GNU General Public License v2.0
794 stars 78 forks source link

Add zsh completion for main duperemove command. #281

Closed VorpalBlade closed 9 months ago

VorpalBlade commented 2 years ago

This PR adds zsh compltion for the main duperemove command. I did not create zsh completion for the other commands as after reading the man pages they appeared to be more of debugging commands and not worth the effort.

Unfortunately I don't have the skill to write an equivalent bash completion file.

VorpalBlade commented 9 months ago

Any reason this PR can't be merged? This has been here for quite a while. And I see the repository has activity again. @JackSlateur

JackSlateur commented 9 months ago

Hello @VorpalBlade

Thank you for your contribution If you could update the changeset to include the modifications I reviewed, that would be awesome

VorpalBlade commented 9 months ago

Thank you for your contribution If you could update the changeset to include the modifications I reviewed, that would be awesome

I don't see any review comments. Did you remember to mark it as finished/ready in Github so it is shared with others?

JackSlateur commented 9 months ago

I don't see any review comments. Did you remember to mark it as finished/ready in Github so it is shared with others?

Ha yes, that would be better

VorpalBlade commented 9 months ago

Fixed (with the one noted caveat in the response to your comments for -R)

JackSlateur commented 9 months ago

Perfect One last issue: when completion is enabled, auto-completion of files no longer works

It may miss a line into the args array to define the file list: when I write duperemove <someoptions> <tab> <tab>, it should be completed by the files in current working directory

This is not clear .. I do not know the words to say this

JackSlateur commented 9 months ago

Awesome

Thank you for your contribution !