markfasheh / duperemove

Tools for deduping file systems
GNU General Public License v2.0
832 stars 82 forks source link

Patch hashfile pragmas for ideal sqlite3 behaviour #284

Closed bbappserver closed 1 year ago

bbappserver commented 2 years ago
t184256 commented 2 years ago

+1 for wal by default, I find it very useful

lorddoskias commented 2 years ago

Has any measurements been performed to see if those options indeed help? Because I run a basic test and at least in the hashing phase none of these options make a difference to performance.

JackSlateur commented 1 year ago

Hello,

WAL mode is enabled (https://github.com/markfasheh/duperemove/commit/1332ed48dc5522631047f06850c6bb37d6eea6b0) to path the way for further improvements

I have checked the other pragmas (most important is the "synchronous" one) and, while it does improve the safety of the database, the performance cost is high As our database is somehow volatile, I do not think this is a good tradeoff: in the worst case, it can be recreated from scratch

Thank you for your contribution!