search

markfasheh / duperemove

Tools for deduping file systems
GNU General Public License v2.0
832 stars 82 forks source link

Incorrect implementation of `is_block_zeroed` #317

Closed amonakov closed 1 year ago

amonakov commented 1 year ago

The new implementation of is_block_zeroed at https://github.com/markfasheh/duperemove/blob/ed75acd1e09585779991763d1400e03a0d57fe3c/file_scan.c#L570-L574 is incorrect, it checks if all bytes in the block are the same, but not if they are all zero (broken by a recent commit).

JackSlateur commented 1 year ago

That's a shame Thank you for your report (fixed by 2a235bf17fbca7bc332b3acc35043c75a22548e3)