search

markfasheh / duperemove

Tools for deduping file systems
GNU General Public License v2.0
689 stars 75 forks source link

file_scan: satisfy clang CFI #326

Closed autumnontape closed 7 months ago

autumnontape commented 8 months ago

dbfile_close_handle takes struct dbhandle*; CFI doesn't like it being called as a function taking void*. This can be worked around by passing -fsanitize-cfi-icall-generalize-pointers, but it seemed easy enough to just make the code compliant.

q66 commented 8 months ago

using a wrong function signature is undefined behavior, so this fix is a correct one

JackSlateur commented 7 months ago

Thank you for you contribution, this has been quite interesting