markfasheh / duperemove

Tools for deduping file systems
GNU General Public License v2.0
689 stars 75 forks source link

Lost support for rhel-7 in 0.14 #340

Closed linuxhw closed 2 months ago

linuxhw commented 3 months ago

Hello!

Error when building duperemove 0.14.1 for rhel-7:

btrfs-util.c: In function 'btrfs_get_fsuuid':
btrfs-util.c:82:6: error: 'struct btrfs_ioctl_fs_info_args' has no member named 'flags'
   82 |  args.flags = BTRFS_FS_INFO_FLAG_METADATA_UUID;
      |      ^
filerec.c: In function 'filerec_open':
filerec.c:250:10: error: 'errno' undeclared (first use in this function)
  250 |    ret = errno;
      |          ^~~~~
filerec.c:32:1: note: 'errno' is defined in header '<errno.h>'; did you forget to '#include <errno.h>'?
   31 | #include "filerec.h"
  +++ |+#include <errno.h>
   32 | 
filerec.c:250:10: note: each undeclared identifier is reported only once for each function it appears in
  250 |    ret = errno;
      |          ^~~~~
btrfs-util.c:82:15: error: 'BTRFS_FS_INFO_FLAG_METADATA_UUID' undeclared (first use in this function)
   82 |  args.flags = BTRFS_FS_INFO_FLAG_METADATA_UUID;
      |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
btrfs-util.c:82:15: note: each undeclared identifier is reported only once for each function it appears in
btrfs-util.c:88:23: error: 'struct btrfs_ioctl_fs_info_args' has no member named 'metadata_uuid'
   88 |  uuid_copy(*uuid, args.metadata_uuid);
      |                       ^
filerec.c:251:15: error: 'ENOENT' undeclared (first use in this function)
  251 |    if (ret != ENOENT || !quiet)
      |               ^~~~~~
filerec.c: In function 'filerec_open_once':
filerec.c:292:10: error: 'ENOMEM' undeclared (first use in this function)
  292 |   return ENOMEM;
      |          ^~~~~~

Duperemove 0.13 builds and works well for rhel-7.

rhel-7 is still most common server os in the world. Could you please support it in new release?

Thanks.

JackSlateur commented 2 months ago

Hello @linuxhw I just installed a centos 7 to reproduce the issue and:

centos 7 is EOL in less than two months, there won't be much changes here I suggest you hurry up and move to a more modern distribution, such as Debian

Best regards,