search

markfguerra / GLWallpaperService

Please submit issues and pull requests to the main repository
https://github.com/GLWallpaperService/GLWallpaperService
Apache License 2.0
218 stars 114 forks source link

AndroidManifest.xml removed from GLWallpaperService #20

Open amadaden opened 12 years ago

amadaden commented 12 years ago

Since the GLWallpaperService is used as a jar and not a stand alone android project this file is not only unnecessary but also problematic.

amadaden commented 12 years ago

Some notes. It turns out that if you have the GLWallpaperService as an Android project and pull this change Eclipse freaks out. This is because Eclipse wrongly thinks that this is a self contained Android project and requires all the files any Android project would. From the way that we use it here this is incorrect.

We treat the GLWallpaperService as a standalone jar that runs Android code. This means that we should set it up as a standard Java project and build it with the Android libraries.

The following are the steps to clean and recreate this project in eclipse. This will fix any issues this branch causes

Clean out the old project. 1) Delete the project in Eclipse but don't select the option to delete the local files 2) Go in to the project folder and delete the .classpath and .project files

Creating the project 1) Use add a new project to add the GLWallpaperService in to Eclipse again. Make the project type a simple Java Project, NOT an Android project. 2) go into 'properties'->'Java build path'. Add your target Android build library and remove the JRE System Library.

That should do it. It's likely destructive to any project specific settings you have so be warned you may have to repair them.

markfguerra commented 11 years ago

While I agree with the idea of this pull request, I think we should take this a step further; we should only have one Android project that contains both test and library code.

Currently we have two projects in this repository, GLWallpaperService and GLWallpaperTest. GLWallpaperService is set up as a library project used by GLWallpaperTest.

Although this seemed like a good idea at the time, this has caused some maintenance work (09ae304 and b714a66) that I would rather not have to deal with in the future. Additionally, it makes setting up the project more complicated for new developers.

What I want to do is have one project, GLWallpaperService, that contains the library and the test wallpapers. When we build a jar, we should just include the library.

We will need to update the info in the developer readme (readme-contribute.txt) after this is done.