search

markfguerra / GLWallpaperService

Please submit issues and pull requests to the main repository
https://github.com/GLWallpaperService/GLWallpaperService
Apache License 2.0
218 stars 114 forks source link

Deprecate redundant interfaces #25

Closed jayschwa closed 11 years ago

jayschwa commented 11 years ago

Many of the interfaces are exact duplicates of ones from GLSurfaceView and, as far as I can tell, add no value. While integrating the latest code into the downstream Rajawali framework, I found these interfaces to be a nuisance. Our classes, which already implement the GLSurfaceView interfaces, were not considered valid to the GLWallpaperService.

GLWallpaperService has been modified to accept the GLSurfaceView interfaces. To maintain backwards compatibility, the redundant GLWallpaperService interfaces have been changed to empty extensions of their GLSurfaceView counterparts, but marked as deprecated. The downside of keeping the interfaces for backwards compatibility is that "GLSurfaceView." had to be prefixed onto many declarations.

Alternate Implementation

26 is a cleaner, less verbose variation of this pull request. However, it breaks backwards compatibility. Only one or the other should be merged.

markfguerra commented 11 years ago

I merged this in at commit 84d0d231