markfinger / python-react

Server-side rendering of React components
MIT License
1.62k stars 116 forks source link

Stop omitting React from the bundles #11

Closed markfinger closed 9 years ago

markfinger commented 9 years ago

Currently React is omitted from the bundles as an optimisation, but a number of folk seem to be hitting the same road block when trying to integrate it. Might be worth turning it off and adding a section to the docs about optimisation which shows how to turn it back on.

There's a downside to this, which is that the bundling process will take longer. Switching django-webpack's bundler to a persistent process with incremental compilation may alleviate that issue. See django-node+django-react's node-server branches for the underlying infrastructure to host the process.

Re #10 Re #8

markfinger commented 9 years ago

Given the shift towards decoupling django-webpack and django-react, this is no longer relevant.

The example (still pending, but mostly completed - pending further API changes) offers suggestions of how to integrate the two, but ultimately I'd prefer an un-opinionated and flexible approach at this stage.