markfinger / python-react

Server-side rendering of React components
MIT License
1.62k stars 116 forks source link

.babelrc not configured correctly in project example #53

Closed Pringels closed 8 years ago

Pringels commented 8 years ago

In the basic rendering example the provided .jsx files make use of es6 syntax. However the .babelrc configuration does not include an es6 compiler plugin.

I propose adding "presets": ["es2015"] to the config.

markfinger commented 8 years ago

Sure, sounds great.

Can you open a PR?

Pringels commented 8 years ago

Sure :)

Pringels commented 8 years ago

Some of the React code used in the examples is also deprecated. Will include fixes for those in my PR

markfinger commented 8 years ago

Cool, thanks for looking into it.

Some of that code has been around for quite a while and is undoubtedly lagging, so feel free to make any changes you deem appropriate :+1:

markfinger commented 8 years ago

Closed by #55