search

markfinger / python-react

Server-side rendering of React components
MIT License
1.62k stars 116 forks source link

API for returning extra items returned by render server #87

Closed sassanh closed 6 years ago

sassanh commented 6 years ago

This is required to be able to use things like react-helmet.

markfinger commented 6 years ago

Thanks for that, it's a good idea.

Given the extra property is actually the output of the render server, the name "extra" seems a bit confusing in this context. Do you mind changing the extra variable&property to data?

If you can also update the docs (README.md) to add the property in https://github.com/markfinger/python-react#basic-usage, that'd be great.

sassanh commented 6 years ago

Sure, will do asap.

sassanh commented 6 years ago

@markfinger OK, I changed the variable name and added the api to the README.md.

markfinger commented 6 years ago

Cool, looks good.

Thanks, @sassanh 😄

markfinger commented 6 years ago

I've published your changes to PyPI as react==4.2.0. Let me know if you run into any issues, but otherwise thanks again for the PR.

markfinger commented 6 years ago

Just noticed a bug when RENDER = False.

react==4.2.1 includes a fix.

sassanh commented 6 years ago

Great, Thanks.