search

markfink / whaaaaat

Inquirer.js port to Python (https://www.npmjs.com/package/inquirer). people blame me for staling this project. I do not have time to work on this right now - whaaaaat do you want me to do? take it offline?
MIT License
83 stars 9 forks source link

Checkbox: selecting all items ignores disabled settings #11

Closed waza-ari closed 6 years ago

waza-ari commented 6 years ago

When using a checkbox with disabled settings, the disabled option is ignored when using the "a" key to add all entries:

Now, the result set will contain all entries instead of all excluding the disabled ones.

https://github.com/finklabs/whaaaaat/blob/dfc69f33e00db495991e60c2a5dc4e5a662b0bb9/whaaaaat/prompts/checkbox.py#L194

markfink commented 6 years ago

thank you for using whaaaaat and for submitting issues and PRs. I am traveling right now and I can not promise to take a look before the weekend. First impression of your PRs is great so I assume they pass the tests, too. BTW, please be aware that prompt_toolkit is undergoing major changes right now so this might significantly impact whaaaaat in the future.

waza-ari commented 6 years ago

thank you for writing and sharing the software! Sorry, but I have to withdraw the PRs again, looks like I got a little bit confused when creating the branches. Since I had to modify the same line for two fixes, the PRs include each other changes... I'm going to clean that up a little bit and then I'll resubmit the PR(s). Going to try the tests as well, however it looks like the're not working in my OS X environment...

I also fixed another issue, going to report it and submit the PR as well. Sorry for the confusion.

Hope you will find time to include the fixes at the weekend!

Thanks and regards Daniel

waza-ari commented 6 years ago

I re-submitted the PRs, now with correct content. I had to submit a combined PR for issues #9, #10 and #11, since the commits modify the same lines of code, thus this should avoid merge conflicts.