markgdev / home-assistant_OctopusAgile

Octopus Agile custom component for Home Assistant
Apache License 2.0
89 stars 32 forks source link

Potential issue in timer code? #78

Open JessFairbairn opened 3 years ago

JessFairbairn commented 3 years ago

Hi, I've been reviewing the timer code and spotted this line, it's possible I'm misunderstanding but it looks like a requirement won't be processed if the day_to attribute is set to "today"? Apologies if this is intentional still getting my head around the codebase.

https://github.com/markgdev/home-assistant_OctopusAgile/blob/ae4b8ee281648ab42fc6cc64d24859e66b70cc28/custom_components/octopusagile/__init__.py#L146

markgdev commented 3 years ago

You’re totally right, that can’t work. I think it’s an indentation issue!