search

markgravity / flutter-survey

3 stars 0 forks source link

[21] [UI] Create HUD progress #35

Closed markgravity closed 3 years ago

markgravity commented 3 years ago

https://github.com/markgravity/flutter-survey/issues/21

What happened

User should be blocked from UI interactive when the app in an action that needs to prevent the user from interacting

Proof Of Work

markgravity commented 3 years ago

I think this PR can only close #21, not #22, as this is the UI implementation, later, you will integrate the logic to hide/show this HUD when invoking an action from a button & calling to the API I suspect.

It's already implemented, I mean show/hide this UI by set isShow

ProgressHUD(
    isShow: true, // show HUD progress
    child: Screen(...)
);

Notes: This is a common UI component, which means it can be used anywhere, so #22 doesn't intend to implement it into a button in a specified screen

sleepylee commented 3 years ago

so #22 doesn't intend to implement it into a button in a specified screen

@markgravity if we have to explain once again in here instead of the ticket that means there is something we did wrong here...imo according to your explanation above, you don't need to create #22 then. But instead, you can maybe add a detail in the ticket where you are integrating Login behavior and during that, it could show this HUD to block the UI.

markgravity commented 3 years ago

so #22 doesn't intend to implement it into a button in a specified screen

@markgravity if we have to explain once again in here instead of the ticket that means there is something we did wrong here...imo according to your explanation above, you don't need to create #22 then. But instead, you can maybe add a detail in the ticket where you are integrating Login behavior and during that, it could show this HUD to block the UI.

Agree! Let's me remove #22