markgravity / flutter-survey

3 stars 0 forks source link

[23] [Integrate] Login screen #54

Closed markgravity closed 3 years ago

markgravity commented 3 years ago

https://github.com/markgravity/flutter-survey/issues/23

What happened

Integrate Login screen

Proof Of Work

https://user-images.githubusercontent.com/17875522/116976660-a9bd9c80-aceb-11eb-8fa3-02ab4b1b6bfc.mov

manh-t commented 3 years ago

The layout is pushed when openning keyboard, I think we don't want to push layout like this 😄

markgravity commented 3 years ago

The layout is pushed when openning keyboard, I think we don't want to push layout like this 😄

I updated it 👍

sleepylee commented 3 years ago

first of all, tips: @markgravity don't use genymotion 😂

markgravity commented 3 years ago

first of all, tips: @markgravity don't use genymotion 😂

@sleepylee whyyyyy? 😓

sleepylee commented 3 years ago

first of all, tips: @markgravity don't use genymotion 😂 @sleepylee whyyyyy? 😓

because using x86 emulator from android studio or just from adb has a higher performance & precision on the device resolution/display/OS (as they are official images). Sometimes you can find more official beta images of the emulator in the official android adb. Running genymotion is like in iOS you're not using the simulator but running another emulation app to display as your device :D

sleepylee commented 3 years ago

I just noticed that your implementation is drawing under the status bar. Don't worry about this for now but definitely, we should take a look at how flutter handles these cases. In native Android, there is some work that needs to be done to make sure on the lower OS our app won't get covered by this; on the higher OS, the status bar background should be transparent. image