search

markgravity / flutter-survey

3 stars 0 forks source link

[25] [Backend] Create survey info #82

Closed markgravity closed 3 years ago

markgravity commented 3 years ago

https://github.com/markgravity/flutter-survey/issues/25

What happened

Create Survey info to prepare for Home screen

Proof Of Work

N/A

manh-t commented 3 years ago

@markgravity ah sorry, I see its usage in #81

sleepylee commented 3 years ago

actually, defining the API endpoint, configure request type, request params are related to the [Backend] ticket/PR, @markgravity FYI. The current one is a part of mapping the response, you will need the part to make the request and response before that as well right?

markgravity commented 3 years ago

actually, defining the API endpoint, configure request type, request params are related to the [Backend] ticket/PR, @markgravity FYI. The current one is a part of mapping the response, you will need the part to make the request and response before that as well right?

Don't get your mean there. Do you mean that this PR should be added into Fetch Survey PR?

sleepylee commented 3 years ago

yes @markgravity they can stay together. If you come back to #81 and remove all the non-related to [Backend] ticket i.e: [UI] implementation, you will see these pieces are related to the backend interaction we are trying to fetch the data from the API

manh-t commented 3 years ago

@markgravity seems you create duplicate survey_info.dart in #81 . Why do you create this PR? 😅

markgravity commented 3 years ago

yes @markgravity they can stay together. If you come back to #81 and remove all the non-related to [Backend] ticket i.e: [UI] implementation, you will see these pieces are related to the backend interaction we are trying to fetch the data from the API

So because in UI ticket, I need SurveyInfo, so that why I created them follow Create Survey Info -> UI -> BE -> Integrate

sleepylee commented 3 years ago

😂 normally in the [UI] ticket, you should just display the mock/hardcoded data. So when we fetch everything, we start making the reactive stream with [Integrate] ticket, that's where it won't messing between different domains.

markgravity commented 3 years ago

😂 normally in the [UI] ticket, you should just display the mock/hardcoded data. So when we fetch everything, we start making the reactive stream with [Integrate] ticket, that's where it won't messing between different domains.

Yea, one thing have learned there 😁

sleepylee commented 3 years ago

or you do the [Backend] ticket first, before doing the [UI] ticket, this is my fav approach so I don't have to fake the data.

Otherwise, how do you explain why a [Backend] ticket #81 contains the UI code? 😄

markgravity commented 3 years ago

or you do the [Backend] ticket first, before doing the [UI] ticket, this is my fav approach so I don't have to fake the data.

Otherwise, how do you explain why a [Backend] ticket #81 contains the UI code? 😄

It needs to rebase 😁

sleepylee commented 3 years ago

@markgravity perhaps just bring all the [Backend] related code to here, we can review and approve them, then #81 which you can turn into a [UI] only ticket, and target for your next sprint.

markgravity commented 3 years ago

@markgravity perhaps just bring all the [Backend] related code to here, we can review and approve them, then #81 which you can turn into a [UI] only ticket, and target for your next sprint.

@sleepylee updated. I will close this PR