search

markguinn / silverstripe-cloudassets

Allows some or all of the assets folder to be located in a cloud storage container (S3, CloudFiles, etc.)
MIT License
19 stars 9 forks source link

SilverStripe 3.0 compatibility #21

Open DarrenInwood opened 9 years ago

DarrenInwood commented 9 years ago

In case you would like a branch that can be installed on older 3.0 projects.

markguinn commented 9 years ago

Thanks @DarrenInwood I'll merge this as soon as I can - probably into a separate branch because of the public/private statics issue. This is good to have available though.

DarrenInwood commented 9 years ago

I didn't do anything with the tests btw. On 15/07/2015 9:59 pm, "Mark Guinn" notifications@github.com wrote:

Thanks @DarrenInwood https://github.com/DarrenInwood I'll merge this as soon as I can - probably into a separate branch because of the public/private statics issue. This is good to have available though.

— Reply to this email directly or view it on GitHub https://github.com/markguinn/silverstripe-cloudassets/pull/21#issuecomment-121562179 .

markguinn commented 9 years ago

That's fine. It's working on a site of yours though?

markguinn commented 9 years ago

I pulled this down as a branch called compat-3.0 but it's failing a lot of tests in Travis (https://travis-ci.org/markguinn/silverstripe-cloudassets/jobs/71474142). I'm happy to leave the branch up but I don't have time to debug all those. If you have time and would like to do take it the rest of the way, feel free. You can either work off a fork and submit a pull request directly to that branch or I could make you a collaborator and you could push directly to the compat-3.0 branch. If you don't have time, no worries. Thoughts?