search

markguinn / silverstripe-cloudassets

Allows some or all of the assets folder to be located in a cloud storage container (S3, CloudFiles, etc.)
MIT License
19 stars 9 forks source link

Corrupted images causes #33

Open dennisa opened 6 years ago

dennisa commented 6 years ago

When there is an upload error due to network issue or abrupt termination of upload (incomplete/corrupted image), it causes a read error and my app returns a internal server error.

CloudImage->getDimensions() probably should just return a 0x0 dimensions in this case

getimagesize(/Volumes/MainStorage/Development/Projects/htdocs/mmyapp/assets/Uploads/Member/45678/Items/14559942-240C-4542-8C2F-54A5F3DC699C-2.png) Image.php:1009 Image->getDimensions(string) CloudImage.php:87 CloudImage->getDimensions(0) Image.php:1022 Image->getWidth() Image.php:705 Image->isWidth(1200) Image.php:377 Image->ScaleWidth(1200) Image.php:526 Image->SetWidth(1200) ViewableData.php:466 ViewableData->obj(SetWidth,Array,1,,) SSViewer.php:99 SSViewer_Scope->getObj(SetWidth,Array,1,,) SSViewer.php:625 SSViewer_DataPresenter->getObj(SetWidth,Array,1,,) SSViewer.php:119 SSViewer_Scope->obj(SetWidth,Array,1,,) SSViewer.php:619