search

markguinn / silverstripe-email-helpers

Silverstripe extension containing SMTP mailer class and some other classes for HTML emails
31 stars 22 forks source link

silverstripe/silverstripe-framework 4.0.0-beta1 #25

Open WillGibson opened 7 years ago

WillGibson commented 7 years ago

I cannot install this at the same time as silverstripe/silverstripe-framework 4.0.0-beta1 because this wants silverstripe/silverstripe-framework ~3.0.

Can this be resolved?

sminnee commented 6 years ago

We'll need to make a SilverStripe 4 compatible version of this module to resolve that, it would be a new major release.

sminnee commented 6 years ago

Note that SS4 now makes use of Swift Mailer, so it's not clear how much that necessitates refactoring this module, or whether it's been replaced by Swift Mailer features.

bummzack commented 6 years ago

A lot of the functionality of this module will be replaced by SwiftMailer. The only thing I can think of that needs to be ported would be the emogrifier part… we use this in shop to inline the CSS styles. Not sure if this warrants it's own module though, it would certainly need some restructuring and integration with SwiftMailer.

@markguinn is no longer maintaining these modules (correct me if I'm wrong, Mark), but I guess he would still merge PRs.

markguinn commented 6 years ago

Yeah, unfortunately I changed jobs and haven't been working in PHP for a while. I've been a little negligent on merging PR's because it's difficult for me to test things locally and the farther I get from working in this stuff the harder it is to just look at the code and insure it's right.

That said, I'll do my best to keep up if y'all submit them and I'm happy to hand the module off if anyone wants to pick it up.

sminnee commented 6 years ago

I've created some "additional committers?" tickets on the 3 modules that are silvershop dependencies. :-)

xini commented 4 years ago

The emogrifier part of this module can be replaced with bummzack/silverstripe-emogrify ^0.2. The rest should be taken care of by SwiftMailer. I think this issue can be closed.