search

markguinn / silverstripe-email-helpers

Silverstripe extension containing SMTP mailer class and some other classes for HTML emails
31 stars 22 forks source link

[TASK] Update pelago/emogrifier dependency to ^2.0.0 #30

Closed oliverklee closed 6 years ago

oliverklee commented 6 years ago

This brings a lot of bug fixes and PHP 7.2 compatibility.

Closes #27

markguinn commented 6 years ago

Thanks for contributing! It looks like the failing unit test is because Emogrifier 2 seems to strip out !important, which is probably fine but you'll need to also update the test in question. Is that something you feel comfortable doing?

oliverklee commented 6 years ago

Yes, I'll take care of that in a minute.

oliverklee commented 6 years ago

Fixed and repushed.

markguinn commented 6 years ago

@oliverklee - Are you aware of anything about v2 of emogrifier that would require a major version bump of this module? Stripping out the !important tags might be enough to count but I'm on the fence.

oliverklee commented 6 years ago

Are you aware of anything about v2 of emogrifier that would require a major version bump of this module?

Not as far as functionality is concerned, but if a project requires both silverstripe-email-helpers as well as emogrifier ^1.2, this would be a breaking change. So I opt for major version bump.