Closed oliverklee closed 6 years ago
Thanks for contributing! It looks like the failing unit test is because Emogrifier 2 seems to strip out !important
, which is probably fine but you'll need to also update the test in question. Is that something you feel comfortable doing?
Yes, I'll take care of that in a minute.
Fixed and repushed.
@oliverklee - Are you aware of anything about v2 of emogrifier that would require a major version bump of this module? Stripping out the !important
tags might be enough to count but I'm on the fence.
Are you aware of anything about v2 of emogrifier that would require a major version bump of this module?
Not as far as functionality is concerned, but if a project requires both silverstripe-email-helpers as well as emogrifier ^1.2, this would be a breaking change. So I opt for major version bump.
This brings a lot of bug fixes and PHP 7.2 compatibility.
Closes #27