search

markguinn / silverstripe-email-helpers

Silverstripe extension containing SMTP mailer class and some other classes for HTML emails
31 stars 22 forks source link

Add TLS support #4

Closed zaucker closed 10 years ago

zaucker commented 10 years ago

Added an option to the constructor to enable TLS secured communication with the SMTP server. Updated README.

zaucker commented 10 years ago

I intended to created a separate pull request for the PHPMailer update, but don't know how to do that.

zaucker commented 10 years ago

In case you are going to merge the PHPMailer update, you might want to update Emogrifier.php as well (https://github.com/jjriv/emogrifier/).

zaucker commented 10 years ago

Please have a look at the require statement in SmtpMailer.php. It would be nicer to make the path relative to code/ or it relative to EMAIL_HELPERS_BASE.

markguinn commented 10 years ago

Thank you! This module was created before composer was widely used and I haven't really updated it since. It looks like both PHPMailer and Emogrifier are on packagist now. I'm actually thinking it makes the most sense to just pull both of those in with composer and let them autoload from the vendor folder. I'll try to have a look at that tonight.

zaucker commented 10 years ago

I am not very familiar with composer and as I wanted to use my fork in a project right now, I just updated PHPMailer in the thirdparty folder. But I agree, if you manage to just pull PHPMailer and Emogrifier from their repository, that would be "cleaner" (perhaps with the drawback that those dependencies could in principal be updated in an incompatible way; doesn't sound very likely, though).

zaucker commented 10 years ago

I added another parameter to the constructor to allow setting of the character encoding of the eMail.

zaucker commented 10 years ago

Thanks!

Fritz

On Thu, 31 Jul 2014, Mark Guinn wrote:

Merged #4.

Reply to this email directly or view it on GitHub: https://github.com/markguinn/silverstripe-email-helpers/pull/4#event-147663473

Oetiker+Partner AG tel: +41 62 775 9903 (direct) Fritz Zaucker +41 62 775 9900 (switch board) Aarweg 15 +41 79 675 0630 (mobile) CH-4600 Olten fax: +41 62 775 9905 Schweiz web: www.oetiker.ch