search

markh-de / KiVar

PCB Assembly Variants for KiCad
MIT License
29 stars 0 forks source link

Incorrect RefDes when reporting rule error #41

Closed honzakutil closed 7 months ago

honzakutil commented 7 months ago

Kivar should report error Rule mixes choices with defined (2) and undefined(1) values (either all or none) for components R13 and R15 in attached pcb. Instead of that, it reports the error multiple times for R18 (last component checked). When the last line of report is clicked, R15 is correctly highlighted, if previous line is clicked, the R13 is correctly highlighted. It looks like error was identified correctly, but refdes was accidentally overwritten by the refdes of component, that was checked at the very end.

Tested with KiCad 8.0 and KiVar 0.2.0-dev6 on machine with win11

example PCB: errors.zip

R13 selected:
R13

R15 selected
R15

markh-de commented 7 months ago

Hi. I'm short of time. Please check 0.2.0-dev7. Thanks!

honzakutil commented 7 months ago

Thanks for quick reply. 0.2.0-dev7 solved the issue.

markh-de commented 7 months ago

Yeah, sorry for the oversight. I recently changed the way footprints are referenced in the internal database. In the past, the refdes was the main key in the database. This prevented you from assigning rules to footprints with an identical refdes. Now we use the footprint's UUID and resolve this to the ref later. And there one lookup was still missing.