Simplified Option checking by removing the need to equate specific types.

markhibberd / pirate

Non-horrible command line parsing.

https://github.com/markhibberd/pirate

BSD 3-Clause "New" or "Revised" License

42 stars 10 forks source link

Closed ssanj closed 9 years ago

etorreborre commented 9 years ago

This should actually be (note the triple equals)

 (ValueParse(None) ~ n).description === None

Because in case of a failure you will get a message saying what is the value of Some(...).

ssanj commented 9 years ago

Good point.

ssanj commented 9 years ago

I've fixed up the PR with === as recommended.

markhibberd commented 9 years ago

@ssanj If you rebase onto the latest master I will merge.

ssanj commented 9 years ago

@markhibberd I have rebased to master.

markhibberd commented 9 years ago

@ssanj Thanks. If you want to rebase you other one on top of master now, I will merge it in as well.