search

markhobson / docker-maven-chrome

Docker image for Java automated UI tests.
https://hub.docker.com/r/markhobson/maven-chrome/
Apache License 2.0
97 stars 81 forks source link

Improve Docker tags #11

Closed markhobson closed 3 years ago

markhobson commented 5 years ago

We currently support the following tags:

These should become:

This requires:

  1. Multiple Docker tags per build, which doesn't appear to be working in Docker Hub. Using a post push hook may be a suitable workaround.
  2. Switching latest from jdk-8 to jdk-16. This will break users currently reliant upon this tag.
markhobson commented 3 years ago

It appears that Docker Hub does now support multiple tags per build. I've added jdk-8 as an alias for latest which is jdk-8/Dockerfile.

I'll update the docs to ask those using latest to start using jdk-8 instead, so we can switch latest to jdk-15 at a later date.

arturds commented 3 years ago

you can add a chrome version on tag too, since last update many of my testes start to fail

markhobson commented 3 years ago

@arturds You can see #2 for a previous discussion about tagging against specific Chrome versions. In summary, we don't since Chrome updates automatically and this image tries to reflect this.

amony-ot commented 3 years ago

Hi Mark,

When i'm using your chrome images its throwing an timeout exception. Even i selected all three java versions.

ChromeDriver was started successfully. [1617639057.803][SEVERE]: Timed out receiving message from renderer: 600.000

markhobson commented 3 years ago

Hi @amony-ot, this sounds similar to #20 but I'm not seeing these messages any more. Could you raise a new issue with more details please?

amony-ot commented 3 years ago

It worked On Jan 15, but the same image is not working recently. When i update it to Firefox its working without any issues. Not sure whether the latest update to 89 version causing this issue.

markhobson commented 3 years ago

@amony-ot It's certainly a Chrome issue, so you won't experience it with Firefox. Could you raise a new issue with more details, rather than comment on this unrelated one please?

markhobson commented 3 years ago

I've now switched latest to point to jdk-16 rather than jdk-8. Please update any image references that need to be fixed at JDK 8 to use the Docker tag jdk-8 - I've added a note to the README.