search

markhobson / docker-maven-chrome

Docker image for Java automated UI tests.
https://hub.docker.com/r/markhobson/maven-chrome/
Apache License 2.0
98 stars 82 forks source link

Versioned docker image (and tags) #53

Open ac-medexter opened 10 months ago

ac-medexter commented 10 months ago

Could you please add version numbers to your docker tags?

I ask because a few days ago your jdk11 image was silently updated to Chrome 119 and all of our test failed because the chrome driver used was no longer compatible.

I read your argumentation in #2 that tests should always run on the latest chrome version, and I could not agree more to that concept. However we would update our test environment on our pace, and only introduce a new chrome version once our drivers can handle them. With chrome versions persisted in docker images and corresponding tags this controlled updates are possible.

markhobson commented 10 months ago

Hi, ChromeDriver is included in this image and is always aligned with the version of Chrome. How comes you're using a different ChromeDriver?

I'm not against tagging images for Chrome versions per se, it's more the extra work to the build process that I'm reluctant to maintain for no real benefit. As a workaround have you considered using digests to fix the image used in your build?

ac-medexter commented 10 months ago

Thank you for suggesting this workaround, using digests for our image works fine for now.

Our tests use Selenium and included drivers in a legacy package, so far the priority of updating Selenium has been too low for anyone starting on it yet. Therefore I wish we could update the Chrome-JDK image on our own pace. The driver dependencies coming with selenium sadly do not support Chrome v119.

The workaround with digests works fine for us until we update all dependencies in our project, if you wish you can close this Issue now. Although I hope including the chrome version in tags will be coming along sometime.

markhobson commented 10 months ago

Glad you can work around it for now. I'll leave this issue open as it's an often requested feature. Personally I doubt I'll invest time in this, but welcome input from those who find it useful.