markhoerth / dremio_client

Apache License 2.0
31 stars 26 forks source link

pyodbc / escape special chars in password #252

Closed insatomcat closed 3 years ago

insatomcat commented 3 years ago

I've seen users for which dremio_client would not work in odbc, and it appears it's because they had ";" characters in their passwords, which messes with the odbc connection string. Apparently escaping the passwords with "{}" works. I've tried on my setup and I didn't encounter a problem. See : https://stackoverflow.com/a/42282362

codecov[bot] commented 3 years ago

Codecov Report

Merging #252 (a4dd965) into master (af5eaf9) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #252   +/-   ##
=======================================
  Coverage   52.61%   52.61%           
=======================================
  Files          24       24           
  Lines        1627     1627           
=======================================
  Hits          856      856           
  Misses        771      771           
Impacted Files Coverage Δ
dremio_client/odbc.py 39.39% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update af5eaf9...a4dd965. Read the comment docs.