search

markhoerth / dremio_client

Apache License 2.0
31 stars 25 forks source link

Just some basic fixes I did just to run queries on both ODBC and REST #96

Open 3runkenzie opened 4 years ago

3runkenzie commented 4 years ago

These are just some issues/problems I found that I made quick fixes for (not PR worthy). These changes are expedient in nature and I didn't want to try to change the whole layout of the code base so I made some naive fixes.

codecov[bot] commented 4 years ago

Codecov Report

Merging #96 into master will decrease coverage by 0.03%. The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
- Coverage   52.98%   52.94%   -0.04%     
==========================================
  Files          24       24              
  Lines        1576     1577       +1     
==========================================
  Hits          835      835              
- Misses        741      742       +1
Impacted Files Coverage Δ
dremio_client/dremio_client.py 38.15% <0.00%> (-0.51%) :arrow_down:
dremio_client/query.py 30.76% <0.00%> (ø)
dremio_client/odbc.py 39.39% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0b49981...5a604c4. Read the comment docs.