markhorgan / click-thru-prototype

Sketch plugin that creates a HTML click-through prototype of a website design
GNU General Public License v3.0
330 stars 39 forks source link

No artboard images are generated #9

Open ChadNicholas opened 7 years ago

ChadNicholas commented 7 years ago

I've got a test file I created to try out the plugin. When I Export to HTML, everything seems to be there except the artboard images. The mobile menu artboard image is generated, but all other artboards are not. Is this an issue with Sketch 42 (36781)?

Using your demo.sketch file it does work, so it's not Sketch 42.

My test file is here: https://drive.google.com/file/d/0B-zSc-ehaF0mVGU2WTlQZXdORms/view?usp=sharing

markhorgan commented 7 years ago

@ChadNicholas I've uploaded a fix for this issue. To update the plugin download the zip file and double click on Click-Thru Prototype.sketchplugin

ChadNicholas commented 7 years ago

I can now see the artboards, thanks!

The mobile menu doesn't work now, though. The mobile-menu.html is generated and the images are as well, but the button assigned as the mobile menu doesn't work. That might be a separate issue, though.

markhorgan commented 7 years ago

@ChadNicholas To see how the mobile menu works, open demo.sketch in the zip file. In the artboard index mobile, the layer mobile menu button is set as the mobile menu button and the hidden layer mobile menu is set as the mobile menu. So when someone clicks on the mobile menu button the visibility of the mobile menu layer is toggled. You have the mobile menu as a separate artboard which isn't supported.

johnjudy commented 7 years ago

I am encountering the same issue, not getting all artboards exported though I do get artboards that are not linked. Just made sure my Java was up to date. Mac OS Sierra 10.12.6

Plug in version 1.1.6

I also uninstalled the plug in and reinstalled, restarted everything etc., no luck. Any advice?

markhorgan commented 7 years ago

@johnjudy If you contact me via my website I can arrange to have a look at your Sketch file to figure out what the issue might be.

markhorgan commented 7 years ago

That should be fixed now in v1.1.7. There was a bug that stopped all the artboards from being exported. You can update the plugin by going to Plugins > Manage Plugins and pressing Update next to the Click-Thru Prototype plugin.

johnjudy commented 7 years ago

Hi Mark That seems to have done the trick. Thanks for the speedy fix and update. Great service.

BTW - I signed up to beta test the next version. Cheers John

On Wed, Oct 11, 2017 at 9:06 AM, Mark Horgan notifications@github.com wrote:

That should be fixed now in v1.1.7. There was a bug that stopped all the artboards from being exported. You can update the plugin by going to Plugins > Manage Plugins and pressing Update next to the Click-Thru Prototype plugin.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/markhorgan/click-thru-prototype/issues/9#issuecomment-335803187, or mute the thread https://github.com/notifications/unsubscribe-auth/AfKt0r9UD-ilB1DswNPNnnc1WEoinE_9ks5srL1ngaJpZM4M90jV .