search

markhuge / grunt-mailgun

MIT License
8 stars 8 forks source link

Running make in postinstall is a dick move #1

Closed markhuge closed 10 years ago

markhuge commented 10 years ago

I shouldn't be distributing coffeescript artifacts that build client side. I forgot I did this.

Next ver bump should ship a js artifact

Zettersten commented 10 years ago

Does this fix:

232 info linkStuff coffee-script@1.6.3 233 verbose linkBins coffee-script@1.6.3 234 verbose link bins [ { coffee: './bin/coffee', cake: './bin/cake' }, 234 verbose link bins 'C:\Projects\Email-Tester\node_modules\grunt-mailgun\node_modules.bin', 234 verbose link bins false ] 235 verbose linkMans coffee-script@1.6.3 236 verbose rebuildBundles coffee-script@1.6.3 237 info install coffee-script@1.6.3 238 info postinstall coffee-script@1.6.3 239 verbose about to build C:\Projects\Email-Tester\node_modules\grunt-mailgun 240 info build C:\Projects\Email-Tester\node_modules\grunt-mailgun 241 verbose linkStuff [ false, 241 verbose linkStuff false, 241 verbose linkStuff false, 241 verbose linkStuff 'C:\Projects\Email-Tester\node_modules' ] 242 info linkStuff grunt-mailgun@0.0.2 243 verbose linkBins grunt-mailgun@0.0.2 244 verbose linkMans grunt-mailgun@0.0.2 245 verbose rebuildBundles grunt-mailgun@0.0.2 246 verbose rebuildBundles [ '.bin', 'coffee-script', 'mailgun' ] 247 info install grunt-mailgun@0.0.2 248 info postinstall grunt-mailgun@0.0.2 249 verbose unsafe-perm in lifecycle true 250 info grunt-mailgun@0.0.2 Failed to exec postinstall script 251 info C:\Projects\Email-Tester\node_modules\grunt-mailgun unbuild 252 info preuninstall grunt-mailgun@0.0.2 253 info uninstall grunt-mailgun@0.0.2 254 verbose true,C:\Projects\Email-Tester\node_modules,C:\Projects\Email-Tester\node_modules unbuild grunt-mailgun@0.0.2 255 info postuninstall grunt-mailgun@0.0.2 256 error grunt-mailgun@0.0.2 postinstall: make build 256 error Exit status 1 257 error Failed at the grunt-mailgun@0.0.2 postinstall script. 257 error This is most likely a problem with the grunt-mailgun package, 257 error not with npm itself. 257 error Tell the author that this fails on your system: 257 error make build 257 error You can get their info via: 257 error npm owner ls grunt-mailgun 257 error There is likely additional logging output above. 258 error System Windows_NT 6.2.9200 259 error command "C:\Utils\Node\node.exe" "C:\Utils\Node\node_modules\npm\bin\npm-cli.js" "install" "grunt-mailgun" 260 error cwd C:\Projects\Email-Tester 261 error node -v v0.10.22 262 error npm -v 1.3.14 263 error code ELIFECYCLE 264 verbose exit [ 1, true ]

markhuge commented 10 years ago

@erik5388 yes.

I externalized the send functionality to an external module. I'll migrate the grunt plugin to the new module after work tomorrow.