Open StargateMC opened 8 years ago
Also popped this in with massivecraft, no point you doing it if they are willing to =D
Let me know if this is still required.
Hi @MarkehMe Factions rejected this idea as they have a proprietary plugin for it.
if you can do this, this would be something that a lot of people would love!!! Allows us to have perpetual worlds without admin intervention kind of thing..
Simply put this idea would be to either:
If you can allow them to be configured individually I'd appreciate it :)
@markehme if you do this I'm more than happy to pay a smallish amount, especially if this works with Factions 2.5 (latest Kcauldron supported)
Working on this for you. Please if you're thinking of supporting my plugin development contribute to my patreon campaign!
Does the latest version of FactionsPlus work on Factions 2.5? I always test on the latest version of Factions so I'm not too sure! If it throws errors, let me know and I'll see if it'll be easy to support! :)
Hi Mark,
Will do some testing with the latest FactionsPlus soon as possible. With regards to the latest factions, I'm sure you are aware of the whole We don't support KCauldron thing... that has me stuck on less than v2.6 :( Fix that too and I'll update in a heartbeat ;)
One last thing - just quickly, if you could allow us to set a list of worlds that do not get regenerated under any circumstance, similar to the "WorldsNoPowerLoss" setting, that would be awesome too.
Will definitely look to donate some funds now!
Absolutely! Making everything as configurable as possible is what I want most :)
Donated :) Sounds great man!
I appreciate it so much! I'll need to add you on Skype :+1:
Haha thanks man! Drakster@live.com.au is the Skype.
Some basic testing with the (second to latest) build of KCauldron + Your latest plugin results in some fun errors... :(
Taken from the errorlog.
, ----------------------------------------
Error Log started on Sat Jan 16 19:55:50 AEDT 2016
----------------------------------------
Server Version: 1.7.10-1614.174 (MC: 1.7.10)
FactionsPlus Version: 2.0.0-beta3
Factions Version: 2.5.0
MassiveCore Version: 7.3.0
----------------------------------------
Error:me/markeh/factionsframework/command/versions/FactionsCommand2XWrapper
----------------------------------------
java.lang.NoClassDefFoundError: me/markeh/factionsframework/command/versions/FactionsCommand2XWrapper
at me.markeh.factionsframework.command.versions.FactionsCommandManager2X.addCommand(FactionsCommandManager2X.java:28)
at me.markeh.factionsplus.commands.CommandManager.enableCmd(CommandManager.java:73)
at me.markeh.factionsplus.commands.CommandManager.add(CommandManager.java:44)
at me.markeh.factionsplus.FactionsPlus.enable(FactionsPlus.java:91)
at me.markeh.factionsplus.FactionsPlusPlugin.onEnable(FactionsPlusPlugin.java:42)
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:316)
at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:368)
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:410)
at org.bukkit.craftbukkit.v1_7_R4.CraftServer.loadPlugin(CraftServer.java:415)
at org.bukkit.craftbukkit.v1_7_R4.CraftServer.enablePlugins(CraftServer.java:349)
at net.minecraft.server.MinecraftServer.func_71243_i(MinecraftServer.java:511)
at net.minecraft.server.MinecraftServer.func_71222_d(MinecraftServer.java:485)
at net.minecraft.server.MinecraftServer.func_71247_a(MinecraftServer.java:445)
at net.minecraft.server.dedicated.DedicatedServer.func_71197_b(DedicatedServer.java:336)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:631)
at java.lang.Thread.run(Unknown Source)
Caused by: java.lang.ClassNotFoundException: Failed to remap class me.markeh.factionsframework.command.versions.FactionsCommand2XWrapper
at org.bukkit.plugin.java.PluginClassLoader.remappedFindClass(PluginClassLoader.java:488)
at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:409)
at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:211)
at java.lang.ClassLoader.loadClass(Unknown Source)
at java.lang.ClassLoader.loadClass(Unknown Source)
... 16 more
Caused by: java.lang.NoClassDefFoundError: com/massivecraft/factions/cmd/FactionsCommand
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(Unknown Source)
at java.security.SecureClassLoader.defineClass(Unknown Source)
at org.bukkit.plugin.java.PluginClassLoader.remappedFindClass(PluginClassLoader.java:476)
... 20 more
----------------------------------------
May need to create a different compatibility layer to support that version of Factions.. let me see what I can do!
If you can I really appreciate it man!
My server is stargatemc.com by the way, it's a hobby project I've had going for quite some time now (Ive only just released a v1.0 server for players to play on).
If you'd like a rank on that, let me know!! :)
PS: Just so you know the main features I use in your plugin are inventory saving and hopefully the world regen, haha.. if that compatibility layer only worked for those two features I'd still be happy.. but not saying you'd do it that way :)
Spent the past few hours supporting <= Factions 2.6.0 and the newer upcoming command structure thats been introduced (their API is getting painful to keep up with! )
Wow, thanks Mark :D
So it looks like we're good for compatibility then?
With regards to Particle Effects and PlayerInventory by the way, I've got access to the source for KCauldron and cant find it anywhere, would that be a bad sign? https://gitlab.prok.pw/KCauldron/KCauldron/repository/archive.zip?ref=master
Sure are. I'm just trying out the development builds of Factions now.
< Sorry I read your post wrong... bit unobservant! >
Fantastic news FP will soon support Factions 2.6 or lower!
I have other news - during testing I found the v0.7.1 build you gave me last year will not support v2.7.0 - but there is no reason why KCauldron cant use v2.7.0. Appears that it might be the last build that works.
Regardless, it didn't work with FP v0.7.1 and v2.0.0 beta so the supporting backwards factions versions is still absolutely awesome!
@MarkehMe Hey man, wondering if we can test the dev build with 2.6 compatibility? That is if its ready for some beta testing!! :)
When a player enters a chunk we store the chunks x and z values along with a timestamp.
Every specified minutes (default, 10) we check if it is past the regeneration time.
By default it will reset using the seed.. however, as seen in the past Minecraft does change their biome generation algorithms now and then. Which is why we will hook into logblock and a few others so we can easily revert changes.
Hi Mark,
I'm assuming you mean leaves a chunk?
Glad you support seed only, I understand the differences in generator code. We cant use either Prism or Logblock with forge items, so glad you've left that in.
What happens to offline players? :)
Does this do a whole chunk at once, or block by block at a slow pace to prevent lag?
Hi @MarkehMe
Is the 2.6 support finished? I'm not seeing any reasons why I cant build based on your code and run with it ( Not including wilderness regen)
Serious issues with the TMap in the configuration file management. Only used for warps and warp passwords at the moment though - I don't recommend using the current version on GitHub.
If an offline player is inside a recently regenerated chunk they at the moment will be stuck inside any blocks/changes/etc.. but I could make it detect this and have them pop to the top-most block?
It will redo the chunk in a seperate thread (i.e. won't effect other actions on the server).
@MarkehMe You are a genius... Top most block is great! If theres any chance you could do a config, would you mind adding support for that to teleport to world spawn if theyre offline? Players may find themselves disoriented if the landscape is changing after logging out... Most servers will have a world spawn that is constant and claimed... we do, it has a stargate on it too....
Separate thread is a win!
I'll hold off on testing then, super excited sorry!
Sure :) I'm working on the TMap issue at the moment, should be fixed in half hour to an hour. If you wanted to test that build that would be awesome.
To use <= 2.6 you need to have an additional plugin i've made called "Factions 2.6 Patches" which just adds classes in for compatibility. :)
Win!!!
I'll try Factions 2.5 with FP as soon as you post it is ready :)
You do need Factions 2.6 Patches, make sure it is in your plugins folder as well!
Let me know if it works. I will trial it in a bit myself
See attached logs, this is with Factions 2.5 (Testing with 2.6 now)
Server Version: 1.7.10-1614.174 (MC: 1.7.10) FactionsPlus Version: 2.0.0-beta4 Factions Version: 2.5.0
java.lang.NoSuchMethodException: me.markeh.factionsframework.command.versions.FactionsCommand2_6Wrapper.setHelp(java.lang.String)
at java.lang.Class.getMethod(Unknown Source)
at me.markeh.factionsframework.command.versions.FactionsCommand2_6Wrapper.
Server Version: 1.7.10-1614.174 (MC: 1.7.10) FactionsPlus Version: 2.0.0-beta4 Factions Version: 2.5.0
java.lang.NoSuchMethodException: com.massivecraft.factions.cmd.CmdFactions.addSubCommand(com.massivecraft.factions.cmd.FCommand) at java.lang.Class.getMethod(Unknown Source) at me.markeh.factionsframework.command.versions.FactionsCommandManager2_6.addCommand(FactionsCommandManager2_6.java:34) at me.markeh.factionsplus.commands.CommandManager.enableCmd(CommandManager.java:73) at me.markeh.factionsplus.commands.CommandManager.add(CommandManager.java:44) at me.markeh.factionsplus.FactionsPlus.enable(FactionsPlus.java:91) at me.markeh.factionsplus.FactionsPlusPlugin.onEnable(FactionsPlusPlugin.java:42) at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:316) at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:368) at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:410) at org.bukkit.craftbukkit.v1_7_R4.CraftServer.loadPlugin(CraftServer.java:415) at org.bukkit.craftbukkit.v1_7_R4.CraftServer.enablePlugins(CraftServer.java:349) at net.minecraft.server.MinecraftServer.func_71243_i(MinecraftServer.java:511) at net.minecraft.server.MinecraftServer.func_71222_d(MinecraftServer.java:485) at net.minecraft.server.MinecraftServer.func_71247_a(MinecraftServer.java:445) at net.minecraft.server.dedicated.DedicatedServer.func_71197_b(DedicatedServer.java:336) at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:631)
Server Version: 1.7.10-1614.174 (MC: 1.7.10) FactionsPlus Version: 2.0.0-beta4 Factions Version: 2.5.0
java.lang.NoSuchMethodException: me.markeh.factionsframework.command.versions.FactionsCommand2_6Wrapper.setHelp(java.lang.String)
at java.lang.Class.getMethod(Unknown Source)
at me.markeh.factionsframework.command.versions.FactionsCommand2_6Wrapper.
Server Version: 1.7.10-1614.174 (MC: 1.7.10) FactionsPlus Version: 2.0.0-beta4 Factions Version: 2.5.0
java.lang.NoSuchMethodException: com.massivecraft.factions.cmd.CmdFactions.addSubCommand(com.massivecraft.factions.cmd.FCommand) at java.lang.Class.getMethod(Unknown Source) at me.markeh.factionsframework.command.versions.FactionsCommandManager2_6.addCommand(FactionsCommandManager2_6.java:34) at me.markeh.factionsplus.commands.CommandManager.enableCmd(CommandManager.java:73) at me.markeh.factionsplus.commands.CommandManager.add(CommandManager.java:45) at me.markeh.factionsplus.FactionsPlus.enable(FactionsPlus.java:91) at me.markeh.factionsplus.FactionsPlusPlugin.onEnable(FactionsPlusPlugin.java:42) at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:316) at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:368) at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:410) at org.bukkit.craftbukkit.v1_7_R4.CraftServer.loadPlugin(CraftServer.java:415) at org.bukkit.craftbukkit.v1_7_R4.CraftServer.enablePlugins(CraftServer.java:349) at net.minecraft.server.MinecraftServer.func_71243_i(MinecraftServer.java:511) at net.minecraft.server.MinecraftServer.func_71222_d(MinecraftServer.java:485) at net.minecraft.server.MinecraftServer.func_71247_a(MinecraftServer.java:445) at net.minecraft.server.dedicated.DedicatedServer.func_71197_b(DedicatedServer.java:336) at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:631)
Server Version: 1.7.10-1614.174 (MC: 1.7.10) FactionsPlus Version: 2.0.0-beta4 Factions Version: 2.5.0
java.lang.NoSuchFieldError: optionalArgs
at me.markeh.factionsframework.command.versions.FactionsCommand2_6Wrapper.
@MarkehMe Same errors with v2.6 :(
Not seeing any functional errors in 2.7 - is regeneration done yet? I turned it on but it doesn't do anything.
Also, is keepinventory on for the new version of FP?
Server Version: 1.7.10-1614.174 (MC: 1.7.10) FactionsPlus Version: 2.0.0-beta4 Factions Version: 2.7.0
java.lang.NoClassDefFoundError: com/massivecraft/massivecore/command/type/Type at me.markeh.factionsframework.command.versions.FactionsCommandManager2_X.addCommand(FactionsCommandManager2_X.java:29) at me.markeh.factionsplus.commands.CommandManager.enableCmd(CommandManager.java:73) at me.markeh.factionsplus.commands.CommandManager.add(CommandManager.java:44) at me.markeh.factionsplus.FactionsPlus.enable(FactionsPlus.java:91) at me.markeh.factionsplus.FactionsPlusPlugin.onEnable(FactionsPlusPlugin.java:42) at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:316) at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:368) at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:410) at org.bukkit.craftbukkit.v1_7_R4.CraftServer.loadPlugin(CraftServer.java:415) at org.bukkit.craftbukkit.v1_7_R4.CraftServer.enablePlugins(CraftServer.java:349) at net.minecraft.server.MinecraftServer.func_71243_i(MinecraftServer.java:511) at net.minecraft.server.MinecraftServer.func_71222_d(MinecraftServer.java:485) at net.minecraft.server.MinecraftServer.func_71247_a(MinecraftServer.java:445) at net.minecraft.server.dedicated.DedicatedServer.func_71197_b(DedicatedServer.java:336) at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:631)
Regeneration is not done yet, no. It will detect it just not act on it :)
Alright. Going to aggressively fix those bugs now
Not finished the merge between the new Type systems they've got going. You need to use even newer development builds for that (not uploaded them yet)
No worries man!! :)
Question, do you not do inventory saving on death in the newer versions?
@markehme how goes the coding sir? Mr Keen bean awaiting orders to test, sir!
As FactionsPlus v2 is a complete rewrite I'm adding features back, but of course I priorities features of higher request :)
Also in regards to saving inventory depending on which land they're in it might be worthwhile using FactionsPerms (http://dev.bukkit.org/bukkit-plugins/factionsperms/) and a Keep Inventory plugin, and apply the permission only to the lands required :)
Haha if that's the way you wanna do it from now on that is awesome! I'll test some keepitems plugins... if they all fail miserably (some of them do) i'll let you know :P
Do you have a rough estimation on how long til the bugs are fixed bud? :) Keen to test regen and/or FP 2.0 w/ Factions 2.6 or 2.7.
Since a new version of Factions has been released today I'm working hard to release it today!
If there is none I will make one, it's pretty simple to make.
Love your work! :)
Think this might fix cauldron support if they've completely rewritten commands ... Sort of?
https://github.com/MassiveCraft/Factions/commit/753310561aded16e8b1be7a9d0cd775e17743d1f
Sent from my iPhone
On 21 Jan 2016, at 11:07 AM, Mark Hughes notifications@github.com wrote:
Since a new version of Factions has been released today I'm working hard to release it today!
— Reply to this email directly or view it on GitHub.
The issue with Cauldron is that the MassiveCraft team have added a reflection utility that tries to use a 1.8 effect, however Cauldron/KCauldron is still on the 1.7 API.. so your best bet is to get them to update to the 1.8 API. I've tried to add my own fixes but.. it's just not going to work.
Kcauldrons authors (at least spanner man) is an bit .... blunt .... unfortunately. [Edited]
They're of the nature that people "need to support cauldron" because they need to be taken seriously. Realistically this is because they don't take being the cauldron Devs seriously.
Do you happen to know if it's possible for me to patch cauldron? I can build a custom jar just not sure what to add/remove/change.
Sent from my iPhone
On 21 Jan 2016, at 11:30 AM, Mark Hughes notifications@github.com wrote:
The issue with Cauldron is that the MassiveCraft team have added a reflection utility that tries to use a 1.8 effect, however Cauldron/KCauldron is still on the 1.7 API.. so your best bet is to get them to update to the 1.8 API. I've tried to add my own fixes but.. it's just not going to work.
— Reply to this email directly or view it on GitHub.
Not entirely sure, sorry. I'm extremely unfamiliar with KCauldron. If they want the support of developers, they should start by supporting to 1.8!
This however, should support older versions of Factions (spent all day on it). Let me know if it works for you:
Oh wow!! Cant wait to get home =D
What can I expect in this version ? FP Functional with 2.6/7? Regen ? :)
Really appreciate your work sir!
Hi @MarkehMe I've tested 2.5 and the plugin loads without error :) Looking forward to regen =D
Great, released it on dev.bukkit - new Factions was released so really had to push that out!
Working on more features tomorrow. :)
@MarkehMe Sounds great bud! :D
Hi Mark,
It'd be really cool for anywhere in the wilderness to automatically reset back to the default block from the world seed over time...
Just a feature request/suggestion :)