russback
commented
4 months ago I am seeing something similar with a simple test to evaluate Pest.
First I have this template:
{% if currentUser %}
<h1>{{ currentUser.email }}</h1>
{% else %}
<h1>Not logged in</h1>
{% endif %}I then have two tests, one with a user logged out, another with a user logged in. The expectation here is that the session is reset in each test:
it ('shows no user', function () {
$text = $this
->get('/test')
->assertOk()
->querySelector('h1')
->getText();
expect($text)->toBe('Not logged in');
});
it ('shows user 1', function () {
$user = 'foo@bar.com';
$text = $this
->actingAs($user)
->get('/test')
->assertOk()
->querySelector('h1')
->getText();
expect($text)->toBe($user);
});What actually happens is this:
Failed asserting that two strings are identical.
at tests/DashboardTest.php:28
24▕ ->assertOk()
25▕ ->querySelector('h1')
26▕ ->getText();
27▕
➜ 28▕ expect($text)->toBe($user);
29▕
30▕ });
31▕
32▕
--- Expected
+++ Actual
@@ @@
-'foo@bar.com'
+'Not logged in'If I comment out either of the tests, the other runs as expected.
I also tried these approaches based on https://pestphp.com/docs/hooks but the result is the same:
beforeEach(function () {
$this->tearDownActingAs();
});
afterEach(function () {
$this->tearDownActingAs();
});Moving the tests into their own file makes no difference either.
I tried calling the method explicitly in each test doesn't resolve this either, for example this, which should be the same as the afterEach hook:
it ('shows user 1', function () {
$user = 'foo@bar.com';
$text = $this
->actingAs($user)
->get('/test')
->assertOk()
->querySelector('h1')
->getText();
expect($text)->toBe($user);
$this->tearDownActingAs();
});And finally, clearing cookies has no effect either https://craft-pest.com/cookies.html#clearcookiecollection:
it ('shows user 1', function () {
$this->clearCookieCollection();
$user = 'foo@bar.com';
$text = $this
->actingAs($user)
->get('/test')
->assertOk()
->querySelector('h1')
->getText();
expect($text)->toBe($user);
});As we're just evaluating test frameworks, I'm not sure if this is the implementation by the plugin, or Pest underlying it.
Pest looks great and the plugin does a fantastic job with zero config setup, but this seems like a fundamental blocker.
If it is of any relevance, this site is running in a DDEV docker container, but I can't see how that would have a bearing on things.
markhuot
Loving Craft Pest so much! This is an incredible plugin.
I’ve been evaluating using Pest instead of Codeception on a large Craft Commerce project.
While testing some functionality around the cart, I’m running into an
Integrity constraint violation:exception.As I dug into this particular exception, it lead me to some deeper questions about Pest.
But first… here’s the issue I hit (and a reduced test case in a repo).
Integrity constraint violation when saving the cart multiple times.
I’ve narrowed down the issue to
Plugin::*getInstance*()->getCarts()->getCart(true)being called in more than one test. Some global state seems to be passed around between tests (those pesky singletons).Here’s an example test that highlights the issue.
Also, here is a DDEV based repo that reproduces the issue.
https://github.com/joshuapease/craft-3-pest
Questions about module & session data being shared across tests.
After running XDebug, I noticed a few things.
When fist test is run
gets the count of the cartIn
craft\commerce\services\Carts::getCart()_cartis nullI also inspected
craft\commerce\services\Customers::getCustomer()_customeris nullWhen second test is run
get the cart while force savingIn
craft\commerce\services\Carts::getCart()_cartis already populated from previous test.In
craft\commerce\services\Customers::getCustomer()_customeris populated from previous testShould modules and session data be reset between tests?
I’ve noticed that Craft’s Codeception connector [seems to reset modules & plugins](https://github.com/craftcms/cms/blob/master/src/test/CraftConnector.php#L93-L115) between request.
Does Craft Pest do something similar?