search

markhuot / craft-pest

https://craft-pest.com
Other
38 stars 11 forks source link

Don't require dev #91

Closed Diewy closed 1 year ago

Diewy commented 1 year ago

First of all, thank you for the Plugin! I truly hope Pest becomes the standard for Craft CMS. 🙌

When I followed the instructions in the readme I added the Plugin as a dev requirement. But afterwards, during a deployment, I got an error:

Installing plugin "pest" ... error: No plugin exists with the handle "pest".

During the deployment process, composer install --no-dev skips the development packages. But as suggested in the readme, the Plugin was locally installed and by that, added to the project.yaml.

markhuot commented 1 year ago

I'm going to merge this for now to avoid confusion, thanks!

FYI: I'm planning on removing the plugin requirement so it won't even go into the project.yaml moving forward. That work is here: https://github.com/markhuot/craft-pest/pull/90 but not yet ready to merge.