Update GraphQLService.php

markhuot / craftql

A drop-in GraphQL server for Craft CMS

Other

320 stars 53 forks source link

Update GraphQLService.php #344

Closed redboer closed 3 years ago

redboer commented 3 years ago

This fixes issue #342

markhuot commented 3 years ago

Interesting, any idea where the 0 comes from? I'll need to check the docs to find it and then this should be good to merge.

redboer commented 3 years ago

I think PHP 8 being more strict it doesn’t accept null as false. In dev mode it will doesn’t fail because it accepts true (even when it basically want an int).

redboer commented 3 years ago

I think it doesn’t even give true in dev mode, but some int value actually.

nelhop commented 3 years ago

When will this be merged? This bug is blocking our development right now...

Wiejeben commented 3 years ago

Pulled changes locally can confirm this is the perfect solution!

mashb1t commented 3 years ago

@markhuot thank you for merging. It would be great if this MR could be released in a stable version asap. Thanks 😊

markhuot commented 3 years ago

This is now included in https://github.com/markhuot/craftql/releases/tag/1.3.7