search

markitosgv / JWTRefreshTokenBundle

Implements a Refresh Token system over Json Web Tokens in Symfony
MIT License
663 stars 159 forks source link

[1.x] Fix PHP 8.2 compat issue in uses of `DateTime::modify()` #349

Closed mbabker closed 1 year ago

mbabker commented 1 year ago

As noted in https://github.com/php/php-src/issues/9950 there is a behavioral change in PHP 8.2 if you make a call like $dateTime->modify('+-300 seconds') as a result of another bug fix in the date/time handling libraries. As the bundle does not enforce TTLs to be a positive number (and the functional tests abuse this a bit), this is a practical fix to ensure anything passing a negative TTL value doesn't catastrophically break.

mbabker commented 1 year ago

Functional CI blocked by #348

Rebased and G2G

shakaran commented 1 year ago

@maxhelias any update missing for merge this to master? Compat with 8.2 is very important for next upgrades. Thanks

maxhelias commented 1 year ago

@shakaran I am not the owner or a collaborator. Thanks

shakaran commented 1 year ago

@mbabker just pinging you in case that you can check this for quick merge. Thanks

mbabker commented 1 year ago

I don't have merge rights here.

shakaran commented 1 year ago

I don't have merge rights here.

who has? By contributions maybe @markitosgv (composer author) or @paulchubatyy ?

mbabker commented 1 year ago

Superseded by #361