markitosgv / JWTRefreshTokenBundle

Implements a Refresh Token system over Json Web Tokens in Symfony
MIT License
663 stars 159 forks source link

[1.x] Add forward compat layer for changed logout listener configuration #350

Open mbabker opened 1 year ago

mbabker commented 1 year ago

See https://github.com/markitosgv/JWTRefreshTokenBundle/pull/347/files/dd75327f8d93d178fa32cbaac929c90a84548ab0#r1037883273 for context

The 2.0 proposal includes changing how the logout listener that handles token and cookie invalidation is configured. In the 2.0 branch, the listener is configured based on the authenticator configuration instead of the global bundle configuration, which allows improving multi-firewall compatibility by configuring the listener differently for each firewall. This provides a compatibility layer to start moving that config in a future 1.x release.

Note that there are a couple of functional B/C breaks here:

This also adds tests for the LogoutEventListener class, previously untested.

mbabker commented 1 year ago

CI's blocked by #348

Rebased and G2G

shakaran commented 10 months ago

@mbabker maxhelias any chance of this get merged soon? which is needed to progress this?

markitosgv commented 7 months ago

@mbabker is it safe to merge this old PR?

mbabker commented 6 months ago

@markitosgv Yes, this is good to merge