search

markitosgv / JWTRefreshTokenBundle

Implements a Refresh Token system over Json Web Tokens in Symfony
MIT License
663 stars 159 forks source link

feat: add support for partitioned cookies #368

Closed EmilePerron closed 10 months ago

EmilePerron commented 1 year ago

This PR adds support for partitioned third-party cookies in a backwards compatible way, as described in #367.

Let me know if you have any comments/feedback!

closes #367

EmilePerron commented 1 year ago

Hello! Would it be possible to know when we can expect this to be reviewed and/or merged, or if there is anything prevent this from moving forward? :)

(Got a thumbs up from a fellow Github user, so we know at least one person other than my colleagues and I seems to be interested in this 😅)

maxhelias commented 1 year ago

Interesting feature indeed!

EmilePerron commented 12 months ago

With Symfony 6.4 and 7.0 being released, this feature is now ready to be used in production once merged and released.

I have added an exception when the partitioned option is set to true while using a Symfony version that does not support it (to be consistent with lexik/LexikJWTAuthenticationBundle, in which the same check was requested and implemented).

The same feature has just been approved & merged into lexik/LexikJWTAuthenticationBundle (see PR 1167), so having the same feature in this refresh token bundle would be the logical next step :)

Let me know if you need anything from me or if you have any feedback regarding this! :)

EmilePerron commented 11 months ago

Is there anything I can do to help this PR move forward? :)

EmilePerron commented 10 months ago

Hi @markitosgv!

Just got back to work after the holidays - hope you and everyone else here had a good time by the way - and was wondering if there is anything I could do to get this PR moving? :)