markjaquith / WP-Stack

A toolkit for creating professional WordPress deployments
1.11k stars 123 forks source link

Remove line 71 in tasks.rb to keep it from setting staging_domain to an empty string, regardless of config setting #11

Closed mgerring closed 11 years ago

mgerring commented 11 years ago

My setup wouldn't work until I removed this line, because for some reason, it sets staging_domain to an empty string no matter what it's set to in config.rb. I don't know whether I was doing something wrong or what, but removing line 71 from lib/tasks.rb worked for me.

This isn't exactly a pull request I just figured it'd be an easier way of showing you where I had a problem.

markjaquith commented 11 years ago

Thanks for reporting! I need the test, in case it's not set, but I was setting like it was a normal Ruby variable, and it's not — it needs to be set with set in Capistrano. This fixed the issue for me. Let me know how that works on your setup.

mgerring commented 11 years ago

Yep, that worked. Thanks!