markjaquith / clerk-sveltekit

Clerk adapter for SvelteKit
Other
128 stars 19 forks source link

SvelteKit 2.0 support #39

Closed methuz closed 6 months ago

methuz commented 6 months ago

npm i clerk-sveltekit

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: myproject@0.0.1
npm ERR! Found: @sveltejs/kit@2.0.6
npm ERR! node_modules/@sveltejs/kit
npm ERR!   dev @sveltejs/kit@"^2.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @sveltejs/kit@"^1.25.1" from clerk-sveltekit@0.3.0
npm ERR! node_modules/clerk-sveltekit
npm ERR!   clerk-sveltekit@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

I'm not sure if it's because sveltekit 2.0. Since sveltekit 2.0 has minor to no breaking backward compatibility. Maybe we can just publish another version that pump sveltekit to 2.0. Any thought?

xeno commented 6 months ago

I just installed it with --force. So far it seems okay.

markjaquith commented 6 months ago

Giving it a test! Have one integration test failing due to some changes in how SvelteKit handles trailing slashes in 2.0.0, but I think I can sort that out.

methuz commented 6 months ago

@markjaquith Thank you!