markjaquith / clerk-sveltekit

Clerk adapter for SvelteKit
Other
159 stars 23 forks source link

No error on invalid sign in and other component issues #71

Closed LiamKrenn closed 2 months ago

LiamKrenn commented 2 months ago

EDIT: This is an issue of #60

  1. Sign In: When a user tries to enter an email or an username, that doesn't exist in the SignIn component - no error or warning is displayed, which could lead the user to believe the site isn't working properly. 422 (Uprocessable Content)
  2. The same happens when trying to sign up with an invalid email - or the email isn't secure enough (for example Password1!) - no user feedback, just redirect. 403 (Forbidden) followed by 422 (Unprocessable Content)
  3. Also when a user tries to reset their password, the OTP page flashes for a brief moment, and then they are redirected to login again. 422 (Unprocessable Content) - but the reset codes still get sent

A feature to display these invalid inputs - and to fix the redirect issues would be very helpful.

wobsoriano commented 2 months ago

Can confirm this issue. Not sure how I missed it. ~This is most likely related to routing in SK~

Thanks for trying out the PR and reporting!

wobsoriano commented 2 months ago

Pushed an update. Should be fixed. Thanks again!

npm i https://pkg.pr.new/wobsoriano/clerk-sveltekit@17d871f
LiamKrenn commented 2 months ago

Seems to be working! Thank you