markjaquith / page-links-to

#WordPressPlugin: Lets you make a WordPress page (or other content type) link to an external URL of your choosing, instead of its WordPress URL.
GNU General Public License v2.0
110 stars 46 forks source link

Open this link in a new tab not working in visual composer post grid #56

Closed moodyjive closed 6 years ago

moodyjive commented 6 years ago

Love the plugin and have used it flawlessly in many Wordpress sites. When using Visual Composer post grid, the custom url will load but ignore the "open this link in a new tab"

moodyjive commented 6 years ago

Actually found out it is due to a Visual Composer class : vc_gitem-link class which does not support opening the link in a new tab. I'm closing this.

markjaquith commented 6 years ago

So that VC class forces it to NOT open in a new tab? Like, it's fighting with my plugin?

moodyjive commented 6 years ago

Yeah I found a thread on Theme forest and this is what Visual Composer said: "Hello, The issue is due to vc_gitem-link class which does not support opening the link in a new tab. You can target it html custom js to remove the class added to it."

https://codecanyon.net/item/visual-composer-page-builder-for-wordpress/242431/comments?page=917

moodyjive commented 6 years ago

Happy to send you the email privately

markjaquith commented 6 years ago

Ah, thanks. The thread had a website where I could see the code that causes it.