markjfine / nrsc5-dui

An enhanced, user-friendly version of nrsc5-gui that is not heavily dependent upon Python processing for audio generation.
GNU General Public License v3.0
139 stars 9 forks source link

Support for NRSC5 executables built for SDRplay functionality? #23

Closed dragonbytes closed 1 year ago

dragonbytes commented 1 year ago

Hi, I use an SDRplay RSPdx device instead of the RTL ones and was able to build and use a forked version of nrsc5 that supports it no problem. A few of the command-line arguments are a little different than the RTL ones though and I wondered if you might be able to add a few tweaks so that nrsc5-dui can spit out the right flags for device id and allow you to tweak the gain settings? I don't know if you are still actively working on the project, but just figured i'd ask! nrsc5-dui is an awesome program!

srs4511351 commented 1 year ago

I just realized that with the trailing zeros in the NRSC5-DUI form, it is a problem. RFGR.IFGR is two integers separated by a “.” A gain of zero.one will be the same as zero.ten (0.10) in the NRSC5-DUI form, but will be sent to the command line as 0.1 in both cases.

It’s hard to explain. I hope you know what I mean.

markjfine commented 1 year ago

If a person really wants to have 1 dB of reduction, they can enter 0.01. The interface currently sends whatever is in the box, e.g., 0.10 as 0.10, 0.1 as 0.1, and 0.01 as 0.01. IOW: The user is entering the same thing they would on the command line, and any perceived confusion is not my problem.

I'm not going to agonize over this, because in order to fully solve it the way you want, I need to use two entries to split the LNA State from the gain reduction, then recombine them for the command line... Given my first statement, it's not worth the effort, so I'm closing this.

srs4511351 commented 1 year ago

The trailing zeros in the NRSC5-DUI form are a problem. RFGR.IFGR is two integers separated by a “.” It is treating it as a real number should not. The interface does not always send what is in the box.

Gain Setting 0.10 sends '-g', '0.1' to NRSC5. Not what is in the box. Gain Setting 0.11 sends '-g', '0.11' to NRSC5, 11 is a gain of ten higher, for only adding 1 to the number.

I want to send '-g', '0.10' to NRSC5 for an IFGR of 10. There's no way to do it. Gain Setting 0.10 sends '-g', '0.1' to NRSC5, oops still 1, not 10.

Gain Setting 0.01 sends '-g', '0.01' to NRSC5, an illegal gain value, which should be a whole number.

markjfine commented 1 year ago

If 0.10 doesn't work for you (it sure did for me) then enter 0.09 or 0.11. I'm certain the 1db either way won't be that critical.

I just got done telling you that the effort to make this work precisely the way you want isn't worth the time to implement and I'm not spending any more time on it.

srs4511351 commented 1 year ago

Yes, and I'm OK with that decision, however your answer indicated that you didn't understand the problem. I see that you understand now, so it's OK.