markjfine / nrsc5-dui

An enhanced, user-friendly version of nrsc5-gui that is not heavily dependent upon Python processing for audio generation.
GNU General Public License v3.0
139 stars 9 forks source link

Cannot bookmark a subchannel without switching the frequency and/or subchannel, stopping, and starting. #42

Open jg303 opened 1 month ago

jg303 commented 1 month ago

Environment: RPi3 with Raspbian, RTL-SDR Blog v3 device.

Issue: Cannot bookmark a subchannel without switching the frequency and/or subchannel, stopping, and starting

Steps to replicate: Tune to 93.3 HD-1 (as an example, this is for any frequency & subchannel). Bookmark the frequency & subchannel. Cannot bookmark anything else.

If I stop and start on 93.3 HD-1, I still cannot bookmark anything else. Must start on a non-bookmarked frequency & subchannel to then bookmark another frequency & subchannel.

Once that frequency & subchannel are bookmarked, I must again select another unbookmarked frequency & subchannel to stop, start, and proceed.

Current workaround: Just following the steps above, or personally modifying the JSON.

Thank you for this software, it has otherwise performed flawlessly!

markjfine commented 1 month ago

I suspected there might be a weird timing/precedence issue with bookmarking that I never corrected in the original nrsc5-gui.

Unable to get to it right now but I'll have a look with a fix in a few days.

Edit:

The app shouldn't allow you to bookmark something if there's already a bookmark in place. In that case you should be able to to just manually edit the one already there from the Bookmarks tab. Conversely, you could also delete the existing bookmark and then have it create a new one from the toolbar, though it might be easier to just ask you if you want to overwrite the existing one and not disable the toolbar button.

It should allow you to create one for a subchannel if there's nothing there without stopping and restarting. I suspect it's something to do with checking the frequency and not the subchannel marker until the subchannel is reacquired.

Again, I'll have a look at the whole toolbar/bookmarking thing when I can.