Open sbyrnes321 opened 8 years ago
Any comment? Colorpy is a really nice package, and so close to being usable in Python 3. it would be great if you could just make this small change and then re-upload to pypi.
Sorry, I have been busy lately and have not had a chance to work on this, even for the simple change.
I will try and get to this on this weekend. Btw: I was not the one who uploaded this to PyPi, somebody else must have done that. But I will also look at trying to upload it there myself.
I appreciate the contribution!
On Thu, Apr 27, 2017 at 9:53 AM, Steven Byrnes notifications@github.com wrote:
Any comment? Colorpy is a really nice package, and so close to being usable in Python 3. it would be great if you could just make this small change and then re-upload to pypi.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/markkness/ColorPy/pull/22#issuecomment-297737370, or mute the thread https://github.com/notifications/unsubscribe-auth/ABiPsSOU4vSnuAZGFIele8XpjUMV2K2oks5r0KvVgaJpZM4If3fC .
Oh, I didn't realize that you weren't the PyPI owner. It looks like the PyPI owner is @fish2000. His repository is already python-3-compatible (thanks to my pull request!) so I just asked him to re-upload to PyPI. ( https://github.com/fish2000/ColorPy/issues/5 )
Well, if you want, you can ask @fish2000 for ownership of the PyPI entry, I think you're kinda entitled to it. Or upload it under a different name. Or just forget about it: I don't think there are any substantive differences between his version and yours. (Unless I'm missing something.)
Is it then your master branch compatible with Python 3.6? Or should I use the one from @sbyrnes321??
Thanks in advance for this great package!
All files now use
from __future__ import absolute_import
, and the Python 3 absolute vs relative import syntax.After this change,
colorpy.test.test()
shows all tests passing in both Python 2.7 and Python 3.5 on my computer.[Copied out of https://github.com/fish2000/ColorPy/pull/2 where I got colorpy running in Python 3 back in Feb 2014, not realizing it was a third-party repository!]