search

marklagendijk / node-toogoodtogo-watcher

Node.js cli tool for monitoring your favorite TooGoodToGo businesses. Docker image available.
MIT License
363 stars 116 forks source link

Allow https for Apprise #236

Open schklom opened 1 year ago

schklom commented 1 year ago

I suggest changing https://github.com/marklagendijk/node-toogoodtogo-watcher/blob/b28b01392452fe7412e31f87d9c871aa2c5eea4e/lib/notifications/apprise-notifier.js#L25 to

    return got.post(`${options.url}/notify/`, {

and https://github.com/marklagendijk/node-toogoodtogo-watcher/blob/b28b01392452fe7412e31f87d9c871aa2c5eea4e/config.defaults.json#L28 to

      "url": "http://apprise:8080",

This would let users specify http or https without being overly complicated.

marklagendijk commented 1 year ago

The intended use is to use Apprise as a sibling container. Https would only be needed in a situation where Apprise is on a different host and behind a proxy setup that adds HTTPS.

schklom commented 1 year ago

I use Apprise for other services, not only this one. For security, I try to separate containers and make connections via my reverse-proxy when possible, just in case.