what are the pre packages needed for?

marklee77 / ansible-role-chrony

ansible role to deploy chrony

GNU General Public License v2.0

2 stars 11 forks source link

what are the pre packages needed for? #5

Open martbhell opened 7 years ago

martbhell commented 7 years ago

Hi,

https://github.com/marklee77/ansible-role-chrony/blob/master/vars/redhat.yml#L3-L5

what are these needed for?

ca-certificates
libselinux-python
epel-release

? (We have removed them in our fork https://github.com/CSC-IT-Center-for-Science/ansible-role-chrony/pull/1 )

marklee77 commented 7 years ago

from what I remember, the epel repository was needed to install chrony. Do you not have this repository enabled on your system?

martbhell commented 7 years ago

I do use epel. But chrony was retired from EPEL and put in the base OS packages some time ago: https://admin.fedoraproject.org/pkgdb/package/rpms/chrony/

What about the ca-certificates? Is there a usecase for verifying the certificate of the NTP server for example?

marklee77 commented 7 years ago

ca-certificates was needed for epel I believe.

Hummm, the commit history is a little confused here. It looks like these dependencies used to be in the centos specific configuration file and then that got merged into the more generic redhat file.

Why not submit a pull request that removes the requirements for your distribution-release?

martbhell commented 7 years ago

By looking at history for vars/main.yml I think I found 1 where it was added to vars/main.yml: https://github.com/marklee77/ansible-role-chrony/commit/abe9cb56e99c78f9fdc072f84b2aaf68d9758b46#diff-6d62b73b3f46cfa11f6466d08cf45303

but it's not clear to me why the requirements were added in the first place, would rather not break something :) We have removed them in our fork to speed up the role (also setting state=present instead of state=latest) helped with that.

I'll see if I can get a PR up, have made some other changes so need to do some cherry picking.

marklee77 commented 7 years ago

sounds good. I mostly use debian/ubuntu, and the vagrant images for redhat seem to be seriously behind the times. I'm happy to have input from anyone who is using this role for other distributions.

martbhell commented 7 years ago

I got something basic working (with Ubuntu 1510). Getting everything in PRs would mean some kind of fancy git work that I haven't figured out yet. A "git rebase master/upstream" gets plenty of conflicts. So I'd need to make PRs for each feature? Seems like a lot of work :/

Here is a comparison: https://github.com/marklee77/ansible-role-chrony/compare/master...CSC-IT-Center-for-Science:pr_for_upstream

And here is a working travis-ci build https://travis-ci.org/CSC-IT-Center-for-Science/ansible-role-chrony