search

marklieberman / downloadstar

Download all items in a webpage that match a pattern
GNU General Public License v3.0
90 stars 16 forks source link

Adapt downthemall/anticontainer #1

Closed SinBirb closed 6 years ago

SinBirb commented 7 years ago

I don't know how it works (maybe some redirect handling?), but the anticontainer extension fixed some links where DownThemAll would only get a blank file, empty index.php,...

Unfortunately I can't give you a test website, because I only used it for an ILIAS installation in my university, where it was almost indispensable.

marklieberman commented 7 years ago

I never used AntiContainer myself, so I am not very familiar with it. However, after reading https://github.com/downthemall/anticontainer/wiki/Writing-plugins, I think redirector/resolver plugins are possible. Sandbox style plugins could possibly be done with eval(), which kinda defeats the point of sandboxing, but WE has limits here. I think I will have a tough time convincing the reviewers on AMO that it could be done safely. I need to discuss it with the addon reviewers.

If you want to help me, point me to some of the more popular anticontainer plugins I can use as reference for my implementation.

marklieberman commented 6 years ago

I've decided this is outside the scope of this addon at this time. I don't have enough time and would prefer to focus on a smaller feature set.