marklieberman / downloadstar

Download all items in a webpage that match a pattern
GNU General Public License v3.0
90 stars 16 forks source link

download links without extension #33

Closed g-i-o-r-g-i-o closed 6 years ago

g-i-o-r-g-i-o commented 6 years ago

For what I've seen, this addon works only when the url - file that you need to download has an extension at the end of the link.

If the link to be downloaded is something like ..../download123/ the downloader doesn't work

In this specific case the page required a login.

bup4gr commented 6 years ago

Same problem shown here https://github.com/marklieberman/downloadstar/issues/27 (second comment). Probably automatic naming/extension can solve the problem.

g-i-o-r-g-i-o commented 6 years ago

No, I don't think that this is the same. Autorename is obviously an essential feature, by in my case downloadstar doesn't download many files at all. In my page there are no files with the same name: when you download by clicking, the files are all saved with different filenames.

Here is a portion of the html code of the page:

<div class="section">
 <h2>Documentazione allegata</h2>
 <!-- Tabella lista attachment -->
<table class="genericList attachmentsList table table-hover">
 <thead>
 <tr>
 <th class="num">#</th>
 <th class="document">Documento</th>
 </tr>
 </thead>
 <tbody>
 <tr>
 <td class="num">1</td>
 <td class="document">
 <img src="/images/pdf.gif" alt="Download Documento">
 <a title="" href="/sourcing/tenders/579683/attachments/1612759/download/">Elenco elaborati progetto esecutivo</a> (323,30 KB)<br>
 </td>
 </tr>
 <tr>
 <td class="num">2</td>
 <td class="document">
 <img src="/images/zip.gif" alt="Download Documento">
 <a title="" href="/sourcing/tenders/579683/attachments/1612732/download/">3.Documentazione progettuale</a> (34,53 MB)<br>
 </td>
 </tr>
 <tr>
 <td class="num">3</td>
 <td class="document">
 <img src="/images/zip.gif" alt="Download Documento">
 <a title="" href="/sourcing/tenders/579683/attachments/1612781/download/">Doc.vis_1</a> (34,85 MB)<br>
 </td>
 </tr>
 <tr>
 <td class="num">4</td>
 <td class="document">
 <img src="/images/zip.gif" alt="Download Documento">
 <a title="" href="/sourcing/tenders/579683/attachments/1612722/download/">1.Documentazione progettuale</a> (35,38 MB)<br>
 </td>
 </tr>
 <tr>
g-i-o-r-g-i-o commented 6 years ago

When you download the files, instead of getting the correct filenames, you simpy find in your download directory many files called "download(number)", without file extension or anything. This is really annoying, since you have to guess the extension of each file. After that, you still have no way to retry the download of the failed files. And why are there some not downloaded files? Because of logins problems, as the downloaded page says. Yet the manual download works.

marklieberman commented 6 years ago

@GianniGi In your example HTML there are no filenames, so there is no "correct" filename. Probably, the server uses the Content-Disposition header to specify a filename. DownloadStar cannot see this header because the web extensions downloads API is missing a lot of features. Also, DS cannot determine the correct extension because it can't get the filename from that header.

The closest thing to a solution would be to collect the text content of the link and allow you to use that as the filename instead.