search

marklieberman / downloadstar

Download all items in a webpage that match a pattern
GNU General Public License v3.0
90 stars 16 forks source link

Download one file from a set of expressions #43

Closed 0xC4N1 closed 6 years ago

0xC4N1 commented 6 years ago

Since the recent update that came with a new UI, selecting a single file from a set of expressions doesn't seem to work as it used to be anymore.

I was using Download Star to quickly download the image with the largest resolution from a site that contained an image in different resolutions. It was possible to accomplish this by providing this regular expression: o_d.jpg|_k.jpg|o_d.png

In case the original resolution o_d.jpg was not available, it would select the smaller resolution _k.jpg. In case both resolution where available, Download Star selected only the original resolution. However now it selects both o_d.jpg and_k.jpg.

How can I accomplish this with the new UI?

marklieberman commented 6 years ago

I believe this feature of only selecting 1 image was actually a matching bug in that was fixed before the new UI. It was never intended to work that way as that regex should check all matching files.

There is currently no way to do priority matching. I suggest clicking the "show only checked items" button and manually deselecting the low resolution matches.

Get Outlook for Androidhttps://aka.ms/ghei36

From: Cani notifications@github.com Sent: Thursday, July 12, 2018 1:58:45 PM To: marklieberman/downloadstar Cc: Subscribed Subject: [marklieberman/downloadstar] Download one file from a set of expressions (#43)

Since the recent update that came with a new UI, selecting a single file from a set of expressions doesn't seem to work as it used to be anymore.

I was using Download Star to quickly download the image with the largest resolution from a site that contained an image in different resolutions. It was possible to accomplish this by providing this regular expression: o_d.jpg|_k.jpg|o_d.png

In case the original resolution o_d.jpg was not available, it would select the smaller resolution _k.jpg. In case both resolution where available, Download Star selected only the original resolution. However now it selects both o_d.jpg and_k.jpg.

How can I accomplish this with the new UI?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/marklieberman/downloadstar/issues/43, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGLGH8vlS2IzYnFn3qiY_TGJETTOIDqIks5uF45VgaJpZM4VNdgC.

0xC4N1 commented 6 years ago

Thank you for your quick reply. I've downgraded to v1.0.2 via https://addons.mozilla.org/de/firefox/addon/download-star/versions/ now and it is working as expected again.

I'm gonna disable the auto update until this feature is implemented again. Would be great if you could comment here if you're gonna implement a priority selecting switch in v2.

marklieberman commented 6 years ago

Out of curiosity, do you have both links and embeds enabled on the bottom left? Usually, the high resolution file is linked from a low resolution thumbnail. If so, just un-select the embeds button to see only the linked highres files.

0xC4N1 commented 6 years ago

No that doesn't fix it. Both resolutions are linked so both get auto selected in v2. But being able to select embedded and linked files at once is a great addition though. Enabling to use priority selection would make it perfect.

marklieberman commented 6 years ago

Can you provide me a sample URL or page? I really cannot picture how 1.0.2 is behaving as you say, because it would have to match in a stateful way that resets when the filename changes but the rest of the URL is the same. I can at least investigate it and think about how I might do a priority matching feature.

0xC4N1 commented 6 years ago

I was going to provide a sample page but I've just noticed the actual issue. It is not the fast filter that matches too many images. It is the built in images filter checkbox that is always enabled when I reopen Download Star v2.0.1. Is it possible to keep the last state of the elements? I just need the fast filter and the media sources at the lower left.

0xC4N1 commented 6 years ago

Never mind. It keeps the last state once you've started a download. :)

marklieberman commented 6 years ago

The popup by default only saves changes to the controls if you hit Download. To make it save all changes immediately, enable it in the options:

image

In both cases, it saves the state of the built-in filters properly for me when I test it.

0xC4N1 commented 6 years ago

Ah now I see it. My mind didn't notice there is another setting so close to the headline above the first input field. The built in filters save their state without downloading only when the save immediately setting is enabled. Seems to be working as it is supposed to be. Thank you for spending your time.